[PATCH 4 of 4] patchbomb: display recipients and ask for confirmation

[Christian Ebert]

* Greg Ward on Wednesday, January 27, 2010 at 22:26:43 -0500
> On Tue, Jan 26, 2010 at 6:28 PM, Mads Kiilerich <mads at kiilerich.com> wrote:
>> FWIW I think it would be nice to see more to convince me _what_ is about to
>> be sent. Most obvious would be the From field and all the full subjects
>> including the --flags. A last review of the intro message could perhaps also
>> be convenient - but I'm not sure about that one ...
> 
> Enthusiastic "+1" from me on the whole patch!  I agree with Mads: I
> would like to see the exact "Subject" line along with "To" and "Cc".

Only the first subject? All subjects? The latter sounds good, but
might be confusing again.

> "From" too, I suppose: I don't want to accidentally use my internal
> work address to send patches to a public mailing list.

Hm. Ok.

I'll experiment. One should keep in mind that the -n/--test
option already exists. At least code-wise I see myself starting
to replicate a lot of what it does already.

A prompt that comes up by default should be extremely short and
concise.

>> Have you considered if that change of behaviour is acceptable considering
>> backward compatibility?
> 
> Considering that patchbomb is currently script-hostile (because of the
> unconditional "Cc" prompt that Christian is getting rid of), I hope
> this change is acceptable.  It will certainly make life easier for
> anyone wishing to script patchbomb in future.
> 
>> Anyway, I like that the prompt is on by default, but think it must be
>> possible to disable it somehow. Perhaps a --noprompt option?
> 
> I like -y with --no-prompt as the long form.

You already found out about -y/--noninteractive ;-)

c
-- 
\black\trash movie    _C O W B O Y_  _C A N O E_  _C O M A_
                     Ein deutscher Western/A German Western

         --->> http://www.blacktrash.org/underdogma/ccc.php