[PATCH 2 of 2] patchbomb: with --verbose display series summary and ask for confirmation

Greg Ward greg-hg at gerg.ca
Sun Jan 31 15:11:27 CST 2010


On Sat, Jan 30, 2010 at 7:07 AM, Christian Ebert <blacktrash at gmx.net> wrote:
> # HG changeset patch
> # User sender
> # Date 1264852764 0
> # Node ID 244554a734aa8c951b6a1bfeede0939d93590c70
> # Parent  b0d68e68c9185059432a31b0357aaf2aedcd975f
> patchbomb: with --verbose display series summary and ask for confirmation
>
> Confirmation check summary:

I love the summary and I love the prompt.  But the fact that both are
activated by --verbose is weird.  --verbose should not change the
level of user interaction, just the amount of output.

Maybe I've got config files on the brain today, but it seems like this
is another good place for a config setting: maybe
patchbomb.sendprompt?  (Better names?)

Idea #1: if patchbomb.sendprompt true, ui.write() the summary and
prompt the user.

Idea #2: keep your existing use of ui.note() for the summary, and have
patchbomb.sendprompt control only the prompt.  (As long as the user
gets a *short* summary before the "are you sure?" prompt.)

I'll play with it and see what I like.

Greg


More information about the Mercurial-devel mailing list