[PATCH 0 of 9] Removed most warnings when python is run with the -3 switch

Nicolas Dumazet nicdumz at gmail.com
Thu Jul 1 22:55:13 CDT 2010


Hello!

2010/7/2 Renato Cunha <renatoc at gmail.com>:
> This patch series intends to remove most (if not all*) warnings generated by
> the python interpreter when run with the -3 switch. Benefits of these changes
> include:
>
>  1- Ability to actually run hg in python3, as 2to3 is unable to make all the
>    needed changes;
>  2- Better correspondence of the code run by the 2.x and 3.x versions.
>
> Most of the changes were straightforward. The changes in url.py (patch 7) are
> so many because the file inheritance was removed from the httpsendfile class
> and explicit wrapper methods were added.
>
> Finally, some regexps were added to check-code to check the presence of tuple
> parameter unpacking, which was removed from python 3.

Nice serie!

I replied to the patches where I had comments. The other uncommented
patches all looked fine to me :)

Thank you!

-Nicolas.

>
> Cheers!
>
> * The 'DeprecationWarning: buffer() not supported in 3.x' still persist, but
> as is discussed in the corresponding patch, buffer is defined as fakebuffer in
> py3k.
>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
>



-- 
Nicolas Dumazet — NicDumZ


More information about the Mercurial-devel mailing list