[PATCH] Allow extensions to add new hgignore syntaxes

Nicolas Dumazet nicdumz at gmail.com
Sun Jul 4 02:42:47 CDT 2010


Hello!

2010/7/4 Jason Harris <jason at jasonfharris.com>:
> I haven't followed the detailed reasons of why we want to do this, but as it stands I am regrettably also firmly against this change...
>

This discussion is relevant:
http://thread.gmane.org/gmane.comp.version-control.mercurial.devel/32331

Basically Boris needs to have Python code dealing with hgignore, and
proposed inclusion in core. We disagreed for security reason
(arbitrary code execution), and proposed adding this in an extension
instead.
So Boris seems to be here, trying modify the core so he can build his
own extension.


> First, regular expressions are pretty dang powerful. Regular expressions are much more "universal" and portable than python code. I am sure there are lots and lots of people using Mercurial, who don't know python. So fundamentally the way ignore patterns are expressed is in regular expressions. If you can't express an ignore pattern in a "regular" expression than you are doing something pretty out of the ordinary and "irregular" so likely the ignore file should be augmented with a few singleton items, or something. What are the use cases for this extra complication?



More information about the Mercurial-devel mailing list