[PATCH 0 of 2] log: slowpath
Nicolas Dumazet
nicdumz at gmail.com
Sun Jul 4 09:20:54 CDT 2010
Hello.
Two interesting discoveries in the so called "slowpath" of walkchangerevs.
1) in "hg log --include foo -r100:110" (slowpath + revision range), I think
that we were walking the full changelog. Reading the index, AND reading
the changelog contents for range(0, len(repo))
That happened because of the increasing windows abstraction, which makes
code a bit more harder to read.
Replacing it by a walk of sorted(wanted_revisions) sounds reasonable and
does not break anything.
2) --removed option apparently had never been implemented. Ever.
I understand it as "only include revisions where fieles were removed". Does
it makes sense in this way, and can you think of any other meaning?
If we agree on the meaning, log docstring probably has to be improved to
include "only"/or be clearer.
Thank you for your time :)
-Nicolas
More information about the Mercurial-devel
mailing list