[PATCH] new command debugignore

[Jason Harris]

On Jul 4, 2010, at 4:55 PM, Benoit Boissinot wrote:

> On Sun, Jul 4, 2010 at 4:37 PM, Martin Geisler <mg at lazybytes.net> wrote:
>> Jason Harris <jason at jasonfharris.com> writes:
>>> Ahh... I guess that would be useful for some people as well. However
>>> for my purposes I need something which implements what I added. But I
>>> can see that it might not be so useful to others... Would you want
>>> this current command with a different name or maybe you guys wouldn't
>>> want it in core Mercurial at all, and I will just leave it in my
>>> patched version which ships with MacHg (once I implement your
>>> suggestions...)
>> 
>> I think it should be an extension -- printing the big, ugly regexp seems
>> of little use as a core feature. You can then ship and enable the
>> extension by default in MacHg.
> 
> I disagree on that. It doesn't look complex, should be easy to
> maintain, it's a debug command and it can be useful.
> On the other hand we do not promise backward compat for debug commands, I think.
> 
> Furthermore it needs refactor in core to have it as an extension. Once
> this refactor is done, the extension is trivial.

Well to be honest I had kept my code independent-ish (if you look at my diff I
modified basically nothing in the core) since I thought I might have to have
this as an extension.

Also if this is an extension then the code I duplicated needs to be duplicated
since someone might try using the extension with previous Mercurial versions.
(ie if I refactor the core for 1.6.1 and then my extension calls into the
refactored core, then my extension will be only valid for Mercurial 1.6.1 and
above.) Thus I had thought that the code would need to be duplicated if it was
going to be external in an extension.

Anyway I am happy either way. I can make it an extension, or it can be included
in core. Just give me the combined crew decision on this one and I will change
accordingly...

Cheers,
  Jas