[PATCH 0 of 2] log: slowpath

Greg Ward greg-hg at gerg.ca
Mon Jul 5 07:43:52 CDT 2010


On Sun, Jul 4, 2010 at 10:20 AM, Nicolas Dumazet <nicdumz at gmail.com> wrote:
> 2) --removed option apparently had never been implemented. Ever.
>   I understand it as "only include revisions where fieles were removed". Does
>   it makes sense in this way, and can you think of any other meaning?
>   If we agree on the meaning, log docstring probably has to be improved to
>   include "only"/or be clearer.

I'm not familiar with the code, but --removed *does* have an effect.
Specifically, it shows the entire history of the file *including* the
changeset that removed it.  My understanding is that it does this by
reading the manifest log, not just the file log, which is why it's so
much slower.

I also have a vague memory that --removed sometimes shows merge
changesets that touch the file but that don't show up when walking the
file log.  I could be wrong about this.  But if that's true, perhaps
it should be renamed to "--thorough" or "--complete", because it shows
the file's entire history, not just the subset of its history that
shows up by walking the file log.

(I have certain co-workers who don't care about the ~90 sec it takes
to run "hg log --removed <file>" -- they want the whole history, not
the fast subset of history that "hg log <file>' gives, by default.  I
can see their point: correctness first, then performance.)

Greg


>
>
> Thank you for your time :)
> -Nicolas
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
>


More information about the Mercurial-devel mailing list