[PATCH 0 of 1 stable] hg.clone() fix/question

Martin Geisler mg at lazybytes.net
Fri Jul 9 15:55:32 CDT 2010


Augie Fackler <durin42 at gmail.com> writes:

> This patch fixes hg.clone() when it is passed a repo instead of a
> source path. This broke a month ago and nobody seems to have
> noticed.

It's actually been noticed three times now... :-(

  http://mercurial.markmail.org/thread/l3cuzjevykmbv3qs
  http://mercurial.markmail.org/thread/r3mpebbpdqpvy2ei

> I only noticed because this pattern of passing a repo object was used
> in some internal tests on Google Code. Perhaps rather than fix this it
> makes more sense to stop supporting passing a repo here and only
> accept URLs? If that's the general feeling, I'll resend to clean up
> the cruft.

I think we've been waiting for Sune's input on this since I believe he
made the original change (from reading Nicolas' commit message).
However, from what Henrik said the other day on IRC, Sune has been (is?)
on holiday.

-- 
Martin Geisler

Mercurial links: http://mercurial.ch/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20100709/92b4504c/attachment.pgp>


More information about the Mercurial-devel mailing list