[PATCH 01 of 15] revlog: add flags for parentdelta

Gilles Moris gilles.moris at free.fr
Mon Jul 12 09:03:46 CDT 2010


On Monday 12 July 2010 03:54:11 pm Gilles Moris wrote:
> > rev: @@ -1109,6 +1113,7 @@
> >          prev = curr - 1
> >          base = self.base(prev)
> >          offset = self.end(prev)
> > +        flags = 0
> >
> >          if curr:
> >              if not d:
> > @@ -1125,7 +1130,7 @@
> >              l = len(data[1]) + len(data[0])
> >              base = curr
> >
> > -        e = (offset_type(offset, 0), l, len(text),
> > +        e = (offset_type(offset, flags), l, len(text),
> >               base, link, self.rev(p1), self.rev(p2), node)
> >          self.index.insert(-1, e)
> >          self.nodemap[node] = curr
>
> Not sure the last 2 hunks improve the clarity of the code.
> Moreover, not directly linked with the patch addition.

OK, this is actually used in patch 5, so may be it should go there.


More information about the Mercurial-devel mailing list