[PATCH 0 of 5] EOL & keyword wrapping (issue2254)

Dirkjan Ochtman dirkjan at ochtman.nl
Wed Jul 14 08:46:40 CDT 2010


On Tue, Jul 13, 2010 at 14:16, Dan Villiom Podlaski Christiansen
<danchr at gmail.com> wrote:
> This series contains 5 patches which address issue2254 and solve a
> possible conflict between the eol & keyword extensions and conversion
> extensions such as hgsubversion.
>
> The fix is to add a usercommitctx() method calling commitctx(), and
> which the keyword & eol must call. I've applied the same fix to the
> bookmarks extension; just in case. The final patch adds an assertion
> which checks that commitctx() hasn't been wrapped.

Hmm, can we get an overview of issues uncovered that lead to this
solution? I.e. in what ways are some commits different from other
commits, what ways are there to solve this problem, and why is this
the best solution?

FWIW, I don't much like the idea of this usercommitctx() API, but
maybe it's just that ugly. Anyway, a summary of the issues would be
useful.

Cheers,

Dirkjan


More information about the Mercurial-devel mailing list