[PATCH 0 of 5] EOL & keyword wrapping (issue2254)

[Dan Villiom Podlaski Christiansen]

On 14 Jul 2010, at 15:46, Dirkjan Ochtman wrote:

> On Tue, Jul 13, 2010 at 14:16, Dan Villiom Podlaski Christiansen
> <danchr at gmail.com> wrote:
>> This series contains 5 patches which address issue2254 and solve a
>> possible conflict between the eol & keyword extensions and conversion
>> extensions such as hgsubversion.
>> 
>> The fix is to add a usercommitctx() method calling commitctx(), and
>> which the keyword & eol must call. I've applied the same fix to the
>> bookmarks extension; just in case. The final patch adds an assertion
>> which checks that commitctx() hasn't been wrapped.
> 
> Hmm, can we get an overview of issues uncovered that lead to this
> solution? I.e. in what ways are some commits different from other
> commits, what ways are there to solve this problem, and why is this
> the best solution?
> 
> FWIW, I don't much like the idea of this usercommitctx() API, but
> maybe it's just that ugly. Anyway, a summary of the issues would be
> useful.

I'll improve the commit messages to address this; I don't think responding on the list will suffice. Future developers are less likely to search the list archives than view the log to find out why something was done :)

--

Dan Villiom Podlaski Christiansen
danchr at gmail.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1943 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20100716/ee71724b/attachment.bin>