[PATCH 10 of 14] changegroup: collect manifest nodes for shallow clone

[Vishakh Harikumar]

On Fri, Jul 16, 2010 at 1:40 PM, Nicolas Dumazet <nicdumz at gmail.com> wrote:
> On Fri, 16 Jul 2010 12:45:18 +0530
> Vishakh H <vsh426 at gmail.com> wrote:
>> -def collector(cl, mmfs, files):
>> +def collector(cl, mmfs, files, sh_cl=set()):
>
> I know that "cl" and "mmfs" are not particurly self-descriptive, but
> what is supposed to mean "sh_cl" here?
> I am also unsure about using an object as a default argument here: it's
> usually considered dangerous as the same object will be used if the
> function is called several times. Why not None?

sh_cl = shallow changelog nodes. It is mentioned in comments when
created in changegroupsubset.
The default argument shouldnt be dangerous here but None will work
in this case (and in some other places with default object argument),
so i will update it.

-- 
vsh