[PATCH 2 of 4] keyword: don't delete possible wrappers for commictx() (see issue2254)
Christian Ebert
blacktrash at gmx.net
Sat Jul 17 07:01:52 CDT 2010
* Dan Villiom Podlaski Christiansen on Friday, July 16, 2010 at 10:41:28 +0200
> We were originally made aware of this shortcoming through the
> EOL extension. hgsubversion raises an IOError if the data
> callback is called on a deleted file.
That is indeed strange, as eol.py does
def commitctx(self, ctx, error=False):
for f in sorted(ctx.added() + ctx.modified()):
if not self._eolfile(f):
continue
data = ctx[f].data()
so in theory it should only call data on added and modified files
only.
> I don't know why the EOL
> extension did this, but from my perspective, that's secondary
> to the fact that it just shouldn't be intercepting, processing
> and validating our commitctx() calls.
Sure.
c
--
\black\trash movie _S A M E_ _T I M E_ _S A M E_ _P L A C E_
--->> http://www.blacktrash.org/underdogma/stsp.php
\black\trash audio _A N O T H E R_ _T I M E_ _A N O T H E R_ _P L A C E_
--->> http://www.blacktrash.org/underdogma/atap.html
More information about the Mercurial-devel
mailing list