[PATCH 2 of 4] keyword: don't delete possible wrappers for commictx() (see issue2254)

Augie Fackler durin42 at gmail.com
Sun Jul 18 09:17:10 CDT 2010


On Jul 17, 2010, at 7:01 AM, Christian Ebert wrote:

> * Dan Villiom Podlaski Christiansen on Friday, July 16, 2010 at  
> 10:41:28 +0200
>> We were originally made aware of this shortcoming through the
>> EOL extension. hgsubversion raises an IOError if the data
>> callback is called on a deleted file.
>
> That is indeed strange, as eol.py does
>
>        def commitctx(self, ctx, error=False):
>            for f in sorted(ctx.added() + ctx.modified()):
>                if not self._eolfile(f):
>                    continue
>                data = ctx[f].data()
>
> so in theory it should only call data on added and modified files
> only.

Except memctx by default describes all files in the context as  
modified, and there's no reasonable API as yet for marking things as  
deleted such that the various status functions work as you'd expect.

Detecting a memctx is unlikely to work well either - I'm trying to  
refactor record so that it'll use one of those instead of reverting  
files in the wc, committing, then restoring the wc.

>
>> I don't know why the EOL
>> extension did this, but from my perspective, that's secondary
>> to the fact that it just shouldn't be intercepting, processing
>> and validating our commitctx() calls.
>
> Sure.
>
> c
> -- 
> \black\trash movie               _S A M E_  _T I M E_  _S A M E_  _P  
> L A C E_
>                          --->> http://www.blacktrash.org/underdogma/stsp.php
> \black\trash audio   _A N O T H E R_  _T I M E_  _A N O T H E R_  _P  
> L A C E_
>                         --->> http://www.blacktrash.org/underdogma/atap.html
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel



More information about the Mercurial-devel mailing list