[PATCH] i18n: use encoding.colwidth() instead of len() for correct column width

FUJIWARA Katsunori fujiwara at ascade.co.jp
Wed Jul 21 08:45:10 CDT 2010


Hi, Martin.

At Mon, 19 Jul 2010 00:49:05 +0200,
Martin Geisler wrote:

> > # HG changeset patch
> > # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
> > # Date 1279382810 -32400
> > # Branch stable
> > # Node ID d342305f7635e607eef62fbfc9dc6f0e13be34d4
> > # Parent  76454cbc11e48d692262843d0c87e81bbb2c053c
> > i18n: use encoding.colwidth() instead of len() for correct column width
> 
> Looks good to me too, pushed as 4f5a6df2af92!
> 
> I edited the test script to take Yuya's comments into account.

Thank you for your adjusting on my patch, but that is not enough for
dash.

As mentioned by Yuya, dash also has the problem that redirection into
non-ASCII UTF-8 named file does not work correctly.

So, we should use the way other than shell redirection.

I'll send additional patch to work correctly with DASH.

--------------------
[FUJIWARA Katsunori]      fujiwara at ascade.co.jp(foozy at lares.dti.ne.jp)


More information about the Mercurial-devel mailing list