[PATCH] i18n: safety writing into non-ASCII named files on any shell implementation

FUJIWARA Katsunori fujiwara at ascade.co.jp
Thu Jul 22 09:25:08 CDT 2010


Hi, Matt.

At Wed, 21 Jul 2010 13:19:43 -0500,
Matt Mackall wrote:

> > > i18n: safety writing into non-ASCII named files on any shell implementation
> > > 
> > > some shell implementation (e.g.: dash) can not handle redirection into
> > > non-ASCII UTF-8 named file correctly.
> > 
> > It works perfectly on dash.
> > Thanks for caring about 8bit-unsafe shell.
> 
> FYI, I was curious how dash could get this so egregiously wrong. Turns
> out that some internal escaping got half-removed rather than fully
> removed. A patch is here:
> 
> http://www.mail-archive.com/dash@vger.kernel.org/msg00238.html
> 
> And released in 0.5.6.1. It apparently only affects redirection with
> filenames containing 0x81 and 0x83. 
> 
> So that suggests two alternative (and simpler) ways to test:
> 
> a) pick new names without the affected bytes
> 
> or
> 
> b) redirect to a temporary file and move the temporary

Thank you for your advice !

I think that (b) seems to be good for this kind purpose.

I'll re-post adjusted patch.

--------------------
[FUJIWARA Katsunori]      fujiwara at ascade.co.jp(foozy at lares.dti.ne.jp)


More information about the Mercurial-devel mailing list