[PATCH 0 of 2] add the template keyword 'children'

Dan Villiom Podlaski Christiansen danchr at gmail.com
Thu Jul 22 16:13:15 CDT 2010


On 22 Jul 2010, at 22:24, Martin Geisler wrote:

> jfh <jason at jasonfharris.com> writes:
> 
>> This patch adds the template keyword 'children'.
> 
> Sure, I like the symmetri of this. Pushed to crew as 6faf015e0ba0 and
> 83eb6b1465bf.

Erm, this may not be as good an idea as it seems, as the symmetry is deceptive. Whereas changectx.parents() is available in the revlog, changectx.children() inspects all changesets following the one called, to see if they are a child.

If children is added to a template, and it's used log all revisions in a repository, log has suddenly gone from O(n) to O(n^2). Although this may not matter in most cases, it can make a *huge* difference for large repositories.

--

Dan Villiom Podlaski Christiansen
danchr at gmail.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1943 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20100722/8d242eff/attachment.bin>


More information about the Mercurial-devel mailing list