[PATCH] changed qimport usage info help to suggest an order that makes more sense

Nicolas Dumazet nicdumz at gmail.com
Thu Jul 22 21:05:34 CDT 2010


2010/7/22 Bill Barry <after.fallout at gmail.com>:
> # HG changeset patch
> # User Bill Barry <after.fallout at gmail.com>
> # Date 1279744202 21600
> # Node ID e79a04818f8fd72158ef63b5b1dc3e6e81ebb213
> # Parent  6b7b99867adaf2f81b8feb59785cd0fbc49ed249
> changed qimport usage info help to suggest an order that makes more sense
>
> diff --git a/hgext/mq.py b/hgext/mq.py
> --- a/hgext/mq.py
> +++ b/hgext/mq.py
> @@ -2889,7 +2889,7 @@
>            _('place existing revisions under mq control'), _('REV')),
>           ('g', 'git', None, _('use git extended diff format')),
>           ('P', 'push', None, _('qpush after importing'))],
> -         _('hg qimport [-e] [-n NAME] [-f] [-g] [-P] [-r REV]... FILE...')),
> +         _('hg qimport [-e] FILE [-r REV] [-n NAME] [-f] [-g] [-P] ...')),


I dislike this patch :)
It's quite usual to find repeatable arguments last, and we'll stick
with this usage.

As we said in another thread, the proper way to take the user through
this is probably to provide him with an example or two in the
docstring, where parameter order is "non-standard".

Regards,
-- 
Nicolas Dumazet — NicDumZ


More information about the Mercurial-devel mailing list