[PATCH 6 of 6] imported patch bdiff.c-py3k-port.diff
Greg Ward
greg-hg at gerg.ca
Tue Jun 8 15:08:45 CDT 2010
On Tue, Jun 8, 2010 at 2:04 PM, Renato Cunha <renato at renatocunha.com> wrote:
> On Tue, Jun 8, 2010 at 14:57, Renato Cunha <renatoc at gmail.com> wrote:
>> /* build binary patch */
>> - rb = PyString_AsString(result);
>> + rb = PyBytes_AsString(result);
>> la = lb = 0;
>
> Alright,
>
> found a bug already, sorry about that. Not all modifications are
> sorrounded by #ifdef IS_PY3K. :/
Also, none of your patches have commit messages. Use "hg qrefresh -e".
And I don't know about MPM's preference, but C code smeared with
repeated occurrences of the same "#if" makes my eyes bleed. It would
be much nicer to factor out a layer that isolates the Python 2.x and
3.x distinction in one place.
Greg
More information about the Mercurial-devel
mailing list