[PATCH 1 of 6] imported patch osutil.c-py3k-port.diff
Renato Cunha
renatoc at gmail.com
Tue Jun 8 21:53:36 CDT 2010
Hello Dan,
On Tue, Jun 08, 2010 at 09:29:58PM +0200, Dan Villiom Podlaski Christiansen wrote:
> On 8 Jun 2010, at 19:57, Renato Cunha wrote:
>
> > +#ifdef IS_PY3K
> > +static PyTypeObject listdir_stat_type = {
> > + PyVarObject_HEAD_INIT(NULL, 0)
> > + "osutil.stat", /* tp_name */
> …
> > static PyTypeObject listdir_stat_type = {
> > PyObject_HEAD_INIT(NULL)
> > 0, /*ob_size*/
>
> Your replacement isn't quite equivalent to the original; you're using
> Py*Var*Object_HEAD_INIT() instead of PyObject_HEAD_INIT(). Is there a reason
> for that, or was it just an oversight?
PyVarObject_HEAD_INIT(type, size) expands to (without quotes):
"{ PyObject_HEAD_INIT(type) size },"
Making "PyObject_HEAD_INIT(NULL) 0" and "PyVarObject_HEAD_INIT(NULL, 0)"
"equivalent".
Regards,
--
Renato Cunha <http://renatocunha.com>
Blog: http://valedotrovao.com
"Whatever happens, happens"
More information about the Mercurial-devel
mailing list