[PATCH 1 of 3] dagparser: parses and formats DAGs as concise text

Matt Mackall mpm at selenic.com
Fri Jun 11 12:11:10 CDT 2010


On Fri, 2010-06-11 at 10:36 +0200, Peter Arrenbrecht wrote:
> On Fri, Jun 11, 2010 at 10:33 AM, Dirkjan Ochtman <dirkjan at ochtman.nl> wrote:
> > On Fri, Jun 11, 2010 at 10:31, Peter Arrenbrecht
> > <peter.arrenbrecht at gmail.com> wrote:
> >> # HG changeset patch
> >> # User Peter Arrenbrecht <peter.arrenbrecht at gmail.com>
> >> # Date 1276163295 -7200
> >> dagparser: parses and formats DAGs as concise text
> >
> > Sorry to dump this on you, but this makes me think, "why not reuse
> > parser.py?". Any good reason other than, it predates it?
> 
> Not so far. Haven't really looked into it. But looking at the
> dagparser again, I think it is sufficiently small to not warrant the
> effort. Do you?

Not really. If we separate things out conceptually as tokenizer, parser,
and interpreter, Peter's code is pretty much all tokenizer and
interpreter. The grammar doesn't allow nesting, so there's not any
parsing in the usual compiler sense.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list