[PATCH] patchbomb: reduce number of opts.get calls

Christian Ebert blacktrash at gmx.net
Tue Jun 15 15:15:30 CDT 2010


* Christian Ebert on Tuesday, June 15, 2010 at 22:05:15 +0200
> # HG changeset patch
> # User Christian Ebert <blacktrash at gmx.net>
> # Date 1276632298 -7200
> # Node ID a950a574ca283d71510b8927a8a96d06db698ece
> # Parent  938fefb57db50cfdb4576fba0a4135def2b0abf0
> patchbomb: reduce number of opts.get calls
> 
> diff --git a/hgext/patchbomb.py b/hgext/patchbomb.py
> --- a/hgext/patchbomb.py
> +++ b/hgext/patchbomb.py
> @@ -234,6 +234,13 @@
>     '''
> 
>     _charsets = mail._charsets(ui)
> +    _bundle = opts.get('bundle')
> +    _date = opts.get('date')
> +    _mbox = opts.get('mbox')
> +    _outgoing = opts.get('outgoing')
> +    _rev = opts.get('rev')
> +    # internal option used by pbranches
> +    _patches = opts.get('patches')

I underscore-prefixed the "opt-variables" to make them clearly
discernable from others with similar or same names even if there
is no clash.

c
-- 
theatre - books - texts - movies
Black Trash Productions at home: http://www.blacktrash.org/
Black Trash Productions on Facebook:
http://www.facebook.com/blacktrashproductions


More information about the Mercurial-devel mailing list