[PATCH] patchbomb: reduce number of opts.get calls

Christian Ebert blacktrash at gmx.net
Tue Jun 15 17:05:04 CDT 2010


* Dirkjan Ochtman on Tuesday, June 15, 2010 at 22:32:33 +0200
> On Tue, Jun 15, 2010 at 22:15, Christian Ebert <blacktrash at gmx.net> wrote:
>> I underscore-prefixed the "opt-variables" to make them clearly
>> discernable from others with similar or same names even if there
>> is no clash.
> 
> Meh, I don't really like that part. How many of these variables would
> collide if they weren't prefixed?

As far as I can see (but that part of the problem, it *is* hard
to see) the only problem is the outgoing() function. Could be
solved by renaming the function to getoutgoing() like getbundle()
etc.

I'm fine with it, even though I made the ugly proposal for a
reason: I find patchbomb quite confusing with its top level and
subfunctions, so I thought it would be nice to know: where the
devil does /this/ "patches" or "rev" variable come from.

c
-- 
theatre - books - texts - movies
Black Trash Productions at home: http://www.blacktrash.org/
Black Trash Productions on Facebook:
http://www.facebook.com/blacktrashproductions


More information about the Mercurial-devel mailing list