[issue2179] Recursion in urllib when pushing with incorrect password

[Augie Fackler]

(+devel)

On Wed, Jun 16, 2010 at 10:03 AM, Mads Kiilerich <mads at kiilerich.com> wrote:
> Augie, it seems like you are the authority here, so can I ask you to give a
> clearer advice?
>
> Do you recommend my hack or should we wait for you to come up with something
> better?

I've not spent any time looking into this - and I don't have time to
work on this today. Your hack seems reasonable, but I don't know
*anything* about urllib2 internals - I've spent my time working on
writing a replacement for httplib. If someone has a good option for
monkeypatching a fix into urllib2, that's great - somewhere in the
timeline for 1.7 I'm hoping to have a viable replacement for our use
of urllib2/httplib working.

>
> /Mads
>
>
> On 06/16/2010 04:00 PM, Augie Fackler wrote:
>>
>> Augie Fackler<durin42 at gmail.com>  added the comment:
>>
>> No, I've not had a chance to get the fix in, things have been unexpectedly
>> hectic.
>>
>> http://code.google.com/p/support/issues/detail?id=3985 is the tracking bug
>> on
>> our end - I'll definitely update it when I fix it. As far as a workaround
>> in
>> hg, something before 1.6 tomorrow sounds like a good idea. The workaround
>> you
>> proposed doesn't look too scary, having not ever looked too deeply into
>> urllib2's internals.
>>
>> ____________________________________________________
>> Mercurial issue tracker<bugs at mercurial.selenic.com>
>> <http://mercurial.selenic.com/bts/issue2179>
>> ____________________________________________________
>
>