[PATCH 0 of 2] setup: don't build inotify extension when <sys/inotify.h> is too old

Renato Cunha renatoc at gmail.com
Wed Jun 16 20:58:01 CDT 2010


Hello,

On Wed, Jun 16, 2010 at 14:30,  <cboos at neuf.fr> wrote:
> This is admittedly because of my too old sys/inotify.h header,
> or some other brokenness on my system, but as I don't want to use
> the inotify extension anyway, I'd prefer to simply avoid building
> inotify when it's anyway going to fail.
>
> To that end, I added an "hasflags" function, which reuses the
> "hasfunction" code.

The idea is interesting, as inotify is not a mercurial requirement.
But wouldn't it be better if, instead of checking for arbitrary flags
in some include files, it was possible for the build process to go on
when non-core stuff failed building?

The first hunk of your second patch didn't apply on my copy, don't
know why, though.

Regards,
-- 
Renato Cunha <http://renatocunha.com>
Blog: http://valedotrovao.com
"Whatever happens, happens"


More information about the Mercurial-devel mailing list