[PATCH] patchbomb: reduce number of opts.get calls (2nd try)
Christian Ebert
blacktrash at gmx.net
Fri Jun 18 04:15:32 CDT 2010
* Christian Ebert on Wednesday, June 16, 2010 at 00:39:25 +0200
> # HG changeset patch
> # User Christian Ebert <blacktrash at gmx.net>
> # Date 1276641441 -7200
> # Node ID 876d98d183cc121f45b985e9ff4670b7bfd2e71f
> # Parent 938fefb57db50cfdb4576fba0a4135def2b0abf0
> patchbomb: reduce number of opts.get calls
>
> Rename outgoing() function to getoutgoing() analogous to
> getbundle() etc. to avoid name conflict.
>
> diff --git a/hgext/patchbomb.py b/hgext/patchbomb.py
> --- a/hgext/patchbomb.py
> +++ b/hgext/patchbomb.py
> @@ -235,7 +235,15 @@
>
> _charsets = mail._charsets(ui)
>
> - def outgoing(dest, revs):
> + bundle = opts.get('bundle')
> + date = opts.get('date')
> + mbox = opts.get('mbox')
> + outgoing = opts.get('outgoing')
> + rev = opts.get('rev')
> + # internal option used by pbranches
> + patches = opts.get('patches')
Should this be improved? Done in a different manner? Or should
the opts.get calls just left as they are? I'm asking because I
want to work (again) on the consistency of the prompt behaviour,
possibly adding a confirmation feature, and it would be nice to
know before whethere anything should be done about the slightly
inflationary opts.get calls.
c
--
theatre - books - texts - movies
Black Trash Productions at home: http://www.blacktrash.org/
Black Trash Productions on Facebook:
http://www.facebook.com/blacktrashproductions
More information about the Mercurial-devel
mailing list