[PATCH] inotify extension: Better implementation of the event string representation

Antoine Pitrou solipsis at pitrou.net
Fri Jun 18 12:10:42 CDT 2010


Renato Cunha <renatoc <at> gmail.com> writes:
> 
> +	if (!join)
> +		join = PyString_FromString("|");
[...]
>  	Py_XDECREF(join);

You must remove this Py_XDECREF() now that `join` is static and meant to retain
its value.

Regards

Antoine.




More information about the Mercurial-devel mailing list