[PATCH] inotify extension: Better implementation of the event string representation
renatoc at gmail.com
Fri Jun 18 13:21:24 CDT 2010
On Fri, Jun 18, 2010 at 01:11:47PM -0500, Matt Mackall wrote:
> I hadn't realized these were static. But still, most of these tests and
> null initializers are redundant. If join isn't set, all of them will
> need allocating.
> It'd be better to do this at module load time with globals though.
> Simpler, no per-call tests, and no delayed failure.
> As this stuff all has zero impact on the 1.6 functionality and the code
> freeze is started, I'm going to drop this stuff for now. We'll try to
> get you merged up shortly after release.
Alright. Then I'll fix it and will resubmit the reviewed chunks shortly after
Renato Cunha <http://renatocunha.com>
"Do, or do not. There is no 'try'".
-- Jedi Master Yoda
More information about the Mercurial-devel