[PATCH 0 of 1] handling of commit messages starting with "#"

Georg Brandl georg at python.org
Sat Jun 19 10:53:04 UTC 2010


Hi,

since I usually format my bug-fixing commit messages like
 "#753: fix something."
I stumbled upon "abort: transplant log file is corrupt" while
transplanting one of these commits, because transplant writes
its log file like the header of a HG changeset patch, and
ignores unknown lines starting with "#".

For hg import, patch.extract() only ignores lines starting with
"# ", so the attached patch makes transplant mirror this behavior.

However, IMO both are still somewhat broken; for example, hg import
will not read a commit message starting with "# " and prompt for
a new message.

If it is accepted that commit messages starting with "# ", and
sometimes "#", will cause problems at least for import and transplant
(and as I just tested, it also affects mq patches), maybe hg
should not let the user use such messages, or at least warn them.

(For transplant and maybe mq, a different format for storing the
changesets/headers could also devised.)

cheers,
Georg


More information about the Mercurial-devel mailing list