[PATCH 1 of 2] encoding: add BOM (byte-order-mark) handling function (issue2162)

Matt Mackall mpm at selenic.com
Sun Jun 20 14:26:54 CDT 2010


On Sat, 2010-06-19 at 22:56 +0900, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya at tcha.org>
> # Date 1276951076 -32400
> # Node ID 19dc05994d6cc2727efbde32c53bcbb1dfbdc83b
> # Parent  e5a2134c083b223bd2998b6694e430e4999caee3
> encoding: add BOM (byte-order-mark) handling function (issue2162)

Ok, these are:

a) a bit late for the code freeze
b) a little questionable (why are people saving config files in UTF-8?)
c) break tests:

--- /export/p4-matt/hg-test/tests/test-hgrc.out 
+++ /export/p4-matt/hg-test/tests/test-hgrc.err 
@@ -38,6 +38,6 @@
 % utf-16-be hgrc
 a.x=y
 % utf-32-le hgrc
-a.x=y
+abort: unknown encoding: utf_32_le, please check your locale settings
 % utf-32-be hgrc
-a.x=y
+abort: unknown encoding: utf_32_be, please check your locale settings

I'm going to duck these for now, let's talk about this for 1.7.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list