Rename qpush --move to --grab

Gilles Moris gilles.moris at free.fr
Wed Jun 23 01:43:56 CDT 2010


On Tuesday 22 June 2010 11:46:08 pm Mads Kiilerich wrote:
> Gilles Moris wrote, On 06/22/2010 11:19 PM:
> > I am not very well placed to bikeshed about wording, but 1.6 will be
> > coming very soon and this is the time for me to speak before it's to
> > late.
> >
> > At one point of time, Martin proposed 'hg qpush --grab' for this option
> > that takes an unapplied patch and push it, instead of pushing the next
> > patch. I hope Mads will not mind that I am promoting 'grab' instead of
> > the original 'hg qpush --move', but I find 'grab' more explicit than
> > 'move' which is kind of generic. I am not opposed to other suggestions if
> > someone has a better idea.
>
> FWIW I'm fine with the change, even though I right now think that
> "promote" or something like "jump in line" would be better. But I have
> no feelings for this functionality - I care much more for qseries --edit
> ;-)
>

Personal taste, but I still prefer grab.

> By the way: --edit got paused because there were requests for more
> documentation and clearer indication that it was a shortcut for the
> risky business of editing the series file. I wonder if that applies to
> move/grab/promote/jump as well?
>

move/grab/promote/jump seems safer than editing the series. The only risk is 
to have a patch that does not apply cleanly.
Editing the series file with applied patches may lead to a corrupted status 
file. May be your edit option would need to require no applied patch before 
allowing edition of the series file.

Regards.
Gilles.




More information about the Mercurial-devel mailing list