[PATCH] qseries: add --edit option for editing series file for current queue

Nicolas Dumazet nicdumz at gmail.com
Wed Jun 23 04:26:41 CDT 2010


2010/6/17 Mads Kiilerich <mads at kiilerich.com>:
> This was discussed on
> http://www.selenic.com/pipermail/mercurial-devel/2010-April/020771.html
> and almost got an ok on
> http://www.selenic.com/pipermail/mercurial-devel/2010-April/020790.html
>
> Are there any more specific comments to how the documentation could/should
> be improved?

I was thinking of a few improvements after this edit phase. Basically,
the idea would be to try to parse the edited file, to try to prevent
mistakes:
* "syntax is invalid. [d]iscard changes/[a]ccept changes/[e]dit again?"
* "you removed x patches and added y patches. [d]iscard
changes/[a]ccept changes/[e]dit again?"

Or is it a bad idea? Of course, a
mq.shutupandletmeborkmyseriesfileifiwant config option could be
possible.


Also, what about prepending, or appending a few comment lines to the
edited file, "hg commit"-style?
"""
HG: Edit this file with care. Lines starting with "HG:" are stripped.
HG:
HG: You are only supposed to reorder lines, one patch name per line
HG:
HG: You are responsible for handling patch dependencies: if patch B
HG: depending on A is put before patch A, hg is likely to have difficulties
HG: applying B alone, and then A on top of B. In this case you will have
HG: to refresh both patches so they apply cleanly.
"""

Or is it too much?

-Nicolas.

>
> /Mads
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
>



-- 
Nicolas Dumazet — NicDumZ


More information about the Mercurial-devel mailing list