contrib/convert-repo crashes and maintenance?

[Mads Kiilerich]

When contrib/convert-repo is run without argument it crashes:

$ contrib/convert-repo
Traceback (most recent call last):
   File "contrib/convert-repo", line 27, in <module>
     convert.convert(u, src, dest, revmapfile, **opts)
   File "/usr/lib/python2.6/site-packages/hgext/convert/__init__.py", 
line 238, in convert
     return convcmd.convert(ui, src, dest, revmapfile, **opts)
   File "/usr/lib/python2.6/site-packages/hgext/convert/convcmd.py", 
line 370, in convert
     dest = hg.defaultdest(src) + "-hg"
   File "/usr/lib/python2.6/site-packages/mercurial/hg.py", line 92, in 
defaultdest
     return os.path.basename(os.path.normpath(source))
   File "/usr/lib/python2.6/posixpath.py", line 312, in normpath
     initial_slashes = path.startswith('/')
AttributeError: 'NoneType' object has no attribute 'startswith'

Fedora report on https://bugzilla.redhat.com/show_bug.cgi?id=607913

That's a bug that can be fixed.

Other errors do also give hard crashes:
$ contrib/convert-repo x
assuming destination x-hg
initializing destination x-hg repository
x does not look like a CVS checkout
x does not look like a Git repository
x does not look like a Subversion repository
x is not a local Mercurial repository
x does not look like a darcs repository
x does not look like a monotone repository
x does not look like a GNU Arch repository
x does not look like a Bazaar repository
cannot find required "p4" tool
Traceback (most recent call last):
   File "contrib/convert-repo", line 27, in <module>
     convert.convert(u, src, dest, revmapfile, **opts)
   File "/usr/lib/python2.6/site-packages/hgext/convert/__init__.py", 
line 238, in convert
     return convcmd.convert(ui, src, dest, revmapfile, **opts)
   File "/usr/lib/python2.6/site-packages/hgext/convert/convcmd.py", 
line 377, in convert
     opts.get('rev'))
   File "/usr/lib/python2.6/site-packages/hgext/convert/convcmd.py", 
line 62, in convertsource
     raise util.Abort(_('%s: missing or unsupported repository') % path)
mercurial.error.Abort: x: missing or unsupported repository

Do we really want to keep and maintain convert-repo? It is in contrib, 
so I assume it can be dropped any time?

/Mads