revset nit: "sort spec must be a string"

Greg Ward greg at gerg.ca
Wed Jun 30 14:29:46 CDT 2010


On Wed, Jun 30, 2010 at 3:14 PM, Greg Ward <greg at gerg.ca> wrote:
> I was just playing around with revsets a bit and noticed an annoyance
> with sort():
>
>  $ hg log -r "sort(descendants(qparent), -rev)"
>  hg: parse error: sort spec must be a string
[...]
> but that's a bit awkward.  Since sort keys are hardcoded strings of
> lowercase letters, I don't see any theoretical reason why quoting is
> required to protect the "-".  Should I try to cook up a patch?

Oh, I see.  I just read the code and saw that my question is nonsense.
 It could only work if sort keys were keywords in the language rather
than ordinary string tokens.  Never mind...

Greg


More information about the Mercurial-devel mailing list