[regression] annotate --follow no longer lists file name (was: Find a regression, win a t-shirt!)

Thomas Arendsen Hein thomas at intevation.de
Tue Mar 2 00:17:04 CST 2010


* Dirkjan Ochtman <dirkjan at ochtman.nl> [20100301 23:07]:
> On Mon, Mar 1, 2010 at 21:57, Thomas Arendsen Hein <thomas at intevation.de> wrote:
> > I just sent "[PATCH] Make annotate --follow an alias for -f/--file
> > to behave like in older versions" to -devel for review.
> 
> Does that still show -n even with -f?

I did not change the behavior of -f/--file, so no, it does not.

If -f/--file should automatically imply -n (unless -c is used) might
be useful, but you did not implement it with your change and maybe
it is too late to do it now.

(Additionally for the behavior of the -f short option the compatible
behavior should be considered as for --follow, as it previously was
a short version of --follow)

> The behavior of showing the
> filename without any revision number was pointed out to be massively
> useless for almost all use cases.

And that's a good reason to have it deprecated.
Spending too much effort in making --follow a useful thing while
keeping it compatible with previous behavior should be avoided.

Or in other words: Nobody should use --follow unless he used it with
previous Mercurial versions, and in that case it should behave like
previous versions did, because if we try to guess we might guess
wrong.

Thomas

-- 
thomas at intevation.de - http://intevation.de/~thomas/ - OpenPGP key: 0x5816791A
Intevation GmbH, Neuer Graben 17, 49074 Osnabrueck - AG Osnabrueck, HR B 18998
Geschaeftsfuehrer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner


More information about the Mercurial-devel mailing list