[PATCH] dirstate: make subrepos an optional arg to status() and walk()

[Anton Markov]

On Fri, Mar 5, 2010 at 12:24 PM, Greg Ward <greg-hg at gerg.ca> wrote:
> On Fri, Mar 5, 2010 at 12:11 PM, Matt Mackall <mpm at selenic.com> wrote:
>>> dirstate: make subrepos an optional arg to status() and walk().
>>>
>>> This makes the incompatible API change in 24ce8f0c0a39 much less
>>> annoying for third-party extension authors who need to maintain
>>> compatibility with Mercurial 1.4 and 1.5.
>>
>> Sorry, I'm not going to take this.
>
> OK.  I was about 70% sure you would say that, but it was worth a shot.
>  Nothing ventured, nothing gained.  ;-)

This may be for the best because we probably want to use subrepos
parameter when it is available. This parameter provides a list of
sub-repositories that the dirstate ignores. Leaving it off will
probably cause dirstate.walk() and dirstate.status() to incorrectly
pick up files in the subrepositories.

In my extended repository status proposal[1], I suggested replacing
subrepos with a more generic "exclude" parameter, possibly in the form
of a match object. This would both clarify the meaning of the
parameter and allow us to also use it for filtering out files that are
managed by the bfiles extension (amongst other uses).

[1] http://selenic.com/pipermail/mercurial-devel/2010-February/019181.html


-Anton