[PATCH STABLE] store: do not add duplicates to the fncache file
Benoit Boissinot
benoit.boissinot at ens-lyon.org
Sun Mar 7 10:11:42 CST 2010
[I somehow missed this email, sorry]
On Wed, Mar 03, 2010 at 04:03:27PM +0100, Adrian Buehlmann wrote:
> On 03.03.2010 15:35, Dirkjan Ochtman wrote:
> > On Wed, Mar 3, 2010 at 15:33, Adrian Buehlmann <adrian at cadifra.com> wrote:
> >> FYI, tonfa responded on IRC with this one. Looks like this won't make it
> >> into 1.5 then :/
> >
> > Why not? I'm pretty sure it will go in.
>
> IMHO, tonfa's patch contains a refactoring bundled together with my
> bugfix, making it harder to review. These two steps should probably be
> separated:
>
> Patch 1: do tonfa's refactoring
> Patch 2: insert my bugfix
>
> tonfa's refactoring is moving the test "path not in fnc" from the
> function fncacheopener into the function add.
>
> There are no other places calling this add.
>
> (although I must say I asked myself as well why tonfa didn't put the
> test into add in the first place back then when he wrote it as it
> currently is. I thought there was a reason for it, but couldn't find it;
> maybe speed?).
Just a mistake I guess.
Now that 1.5 is released I'll have a look if it's worth removing other
potiental duplicates.
regards,
Benoit
--
:wq
More information about the Mercurial-devel
mailing list