[PATCH] churn: use ui.progress instead of --progress

[Augie Fackler]

On Thu, Mar 11, 2010 at 8:31 AM, Martin Geisler <mg at lazybytes.net> wrote:
> Benoit Boissinot <bboissin at gmail.com> writes:
>
>> On Thu, Mar 11, 2010 at 03:01:54PM +0100, Martin Geisler wrote:
>>> Benoit Boissinot <bboissin at gmail.com> writes:
>>>
>>> > On Wed, Mar 10, 2010 at 7:35 PM, Eric Eisner <ede at mit.edu> wrote:
>>> >> # HG changeset patch
>>> >> # User Eric Eisner <ede at mit.edu>
>>> >> # Date 1268246122 18000
>>> >> # Node ID 6f454558cd628c86176373508c1d57d11530efbb
>>> >> # Parent  6227c8d669d52e9e29daa72b0cc9c072acc20ac4
>>> >> churn: use ui.progress instead of --progress
>>> >>
>>> >>           ('', 'aliases', '', _('file with email aliases')),
>>> >> -          ('', 'progress', None, _('show progress'))],
>>> >> +          ],
>>> >>          _("hg churn [-d DATE] [-r REV] [--aliases FILE] [--progress] [FILE]")),
>>> >
>>> > You missed the synopsis. Maybe the option should be left, and it would
>>> > change the configuration in ui.
>>>
>>> I'm fine with removing the option completely and consolidating our
>>> progress bars so they all use the extension. We should just put a note
>>> about it in the release notes.
>>
>> Maybe at one point hgext/progress.py should be moved into core, and
>> enabled with a global --progress flag.
>
> I definitely think we should move it into core -- I love it everytime I
> see a progress bar pop up. I even lovered the delay to 0.5 seconds to
> get more of them :-)

I'd be +1 on having it in core - I think that progress feedback is one
place where git out of the box really eats our lunch.

> When it's in the core, I think it should just work right out of the box.
> People can (probably) disable it by setting delay to a negative value or
> something like that.

progress.disable = <bool> rather than a magic int, but yeah :)

>
> --
> Martin Geisler
>
> Fast and powerful revision control: http://mercurial.selenic.com/
>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
>
>