[PATCH resend] churn: use ui.progress instead of --progress

[Benoit Boissinot]

On Thu, Mar 11, 2010 at 6:28 PM, Augie Fackler <lists at durin42.com> wrote:
> On Thu, Mar 11, 2010 at 11:00 AM, Eric Eisner <ede at mit.edu> wrote:
>>> A little late on this, but I think I'd prefer 'changes' in instead of
>>> 'churning changes' for the item, since the former would use much less
>>> space next to the progress bar, and is more consistent with other uses
>>> of the progress API.
>>
>> I was going off of the precedent I saw in "bundle changes," "looking
>> for similarities," etc. But I see the argument for a one-word
>> standard.
>
> Yeah, bundle changes is one I'm not thrilled with. looking for changes
> definitely feels like it eats up too much of an 80-column terminal to
> me.

Please devise a best-practice for progress keywords, I'm usually
struggling to find good words.

cheers,

Benoit
>
>>
>>> Also, why the state dict when all it seems to store is a count?
>>> Shouldn't that be an integer? (disclaimer: I'm going off the unidiff
>>> here, with minimal familiarity with the code in question).
>>
>> The progress code was in an inner function which could not modify an
>> integer in the outer scope. I was just lazy and didn't change the
>> existing structure.
>>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
>