[PATCH] churn: use ui.progress instead of --progress

Steve Borho steve at borho.org
Thu Mar 11 21:10:11 CST 2010


On Thu, Mar 11, 2010 at 6:52 PM, Augie Fackler <lists at durin42.com> wrote:
>
> On Mar 11, 2010, at 5:42 PM, Brodie Rao wrote:
>
>> On Mar 11, 2010, at 6:32 PM, Sune Foldager wrote:
>>
>>> On 12-03-2010 00:31, Dan Villiom Podlaski Christiansen wrote:
>>>> On 11 Mar 2010, at 17:31, Augie Fackler wrote:
>>>>
>>>>> progress.disable = <bool> rather than a magic int, but yeah :)
>>>>
>>>> Isn't that naming a bit backwards? In my opinion, having either ‘progress.enabled’ or ‘progress.show’ — defaulting to true — seem more logical choices. As long as the extension is separate from core, the option could simply default to ‘true’.
>>>> I hope I'm not nitpicking too much :)
>>>
>>> I think this was discussed on IRC or the list or both... but not sure. I
>>> agree, though :=)
>>
>> If it were going into core, I'd expect it to be something like ui.progress=True/False.
>>
>> I also agree that negative options like that are weird.
>
> Agreed, but that's the option thg already uses. progress.disabled is mostly so other tools can disable the progress bar programmatically.

As silly as this is, I'm pretty sure I wanted it the other way as
well, and was talked out of it on IRC.  It's kind of a moot point now,
though.

--
Steve Borho


More information about the Mercurial-devel mailing list