[PATCH 1 of 2] fix run-tests.py -jX after i broke it

Benoit Boissinot bboissin at gmail.com
Thu Mar 25 02:39:12 CDT 2010


On Thu, Mar 25, 2010 at 5:25 AM, Nicolas Dumazet <nicdumz at gmail.com> wrote:
> 2010/3/23 Ronny Pfannschmidt <Ronny.Pfannschmidt at gmx.de>:
>> # HG changeset patch
>> # User Ronny Pfannschmidt <Ronny.Pfannschmidt at gmx.de>
>> # Date 1269354137 -3600
>> # Node ID 135322fa86c91581f88ce887166d2c317259419d
>> # Parent  2ed667a9dfcb6fd28667bbd86bac1daa5146672b
>> fix run-tests.py -jX after i broke it
>>
>> diff --git a/tests/run-tests.py b/tests/run-tests.py
>> --- a/tests/run-tests.py
>> +++ b/tests/run-tests.py
>> @@ -144,7 +144,8 @@ def parseargs():
>>     (options, args) = parser.parse_args()
>>
>>     # jython is always pure
>> -    options.pure = options.pure or 'java' in sys.platform
>> +    if 'java' in sys.platform:
>> +        options.pure = True
>>
>
> If it's pushed, it must change something, but I have to confess that I
> dont see what is changing in this diff/reading the log.
> it seems to me that both versions are doing "pure2 = pure or is_java".
> What am I missing? :s

I guess if option.pure is None, we want to keep it that way, not make
it False (just a guess).

Benoit


More information about the Mercurial-devel mailing list