[PATCH stable] mq: fixed ENOENT when qrename to new/directory.patch

Yuya Nishihara yuya at tcha.org
Tue Mar 30 06:41:18 CDT 2010


Benoit Boissinot wrote:
> On Sun, Mar 28, 2010 at 8:43 AM, Yuya Nishihara <yuya at tcha.org> wrote:
> > # HG changeset patch
> > # User Yuya Nishihara <yuya at tcha.org>
> > # Date 1269757391 -32400
> > # Branch stable
> > # Node ID 9d85dcd645627098ff559df1d7f25cde5666bfac
> > # Parent  1e819576e9264bd749ed6cafcbbc52f51753f189
> > mq: fixed ENOENT when qrename to new/directory.patch
> >
> > MQ patch name can contain slashes, e.g. 'foo/bar.patch'.
> >
> > Currently "qnew foo/bar.patch" works, but
> > "qrename foo/bar.patch new/dir.patch" fails with
> > "No such file or directory".
> 
> There are lots of other problems if we allow '/' in patchnames (hg
> qrename foo foo/bar ; hg qrename bar foo).
> Maybe qnew should disallow them instead?

Hmm, but there's already the code meant to support directories:

> changeset:   3080:82c9d1aac308
> user:        Brendan Cully <brendan at kublai.com>
> date:        Wed Sep 13 08:57:08 2006 -0700
> files:       hgext/mq.py tests/test-mq-qrename tests/test-mq-qrename.out
> description:
> Make qrename handle directory targets; closes #333.

and the issue:

http://mercurial.selenic.com/bts/issue333

I'm okay to disallow slashes as patchnames, but is there a fun of
that feature?

Yuya,


More information about the Mercurial-devel mailing list