[PATCH stable] mq: fixed ENOENT when qrename to new/directory.patch

[Benoit Boissinot]

On Wed, Mar 31, 2010 at 10:21:04AM -0700, Brendan Cully wrote:
> On Wednesday, 31 March 2010 at 08:37, Dirkjan Ochtman wrote:
> > On Tue, Mar 30, 2010 at 23:12, Brendan Cully <brendan at kublai.com> wrote:
> > > I added it because there was a bug about it, not because I myself
> > > needed the feature. So I don't have a strong opinion, but I'd still
> > > prefer if we kept it. I think it probably helps keep large patch
> > > series (larger than I personally use, but mq has always been meant to
> > > handle very large series) organized.
> > 
> > I think many other separation characters could used instead, keeping
> > the same nice organization properties (., -, _, =, whatever), so I
> > don't particularly by this argument. So then it seems like a rather
> > slim benefit for taking into account '/' everywhere in patch names.
> 
> Couldn't you make the same argument for the main repo? Supporting
> subdirectories complicates things for regular hg too, so why not
> disallow them?

The difference I see is that contrary to the working dir, most mq users
don't touch .hg/patches, they might even not care about the way patches
are stored. We could urllib.quote() the filenames it probably wouldn't
make a difference for most people (except potential quilt users).

My point was more the following: contrary to the working dir, the fact
that patches are stored as-is isn't explicit, if I didn't knew how it
works I would be puzzled not to be able to have both foo and foo/bar in
my mq serie.

Cheers,

Benoit

-- 
:wq