[PATCH 0 of 4] keyword: clean up verbosity and kwdemo

Martin Geisler mg at lazybytes.net
Wed Mar 31 17:31:31 CDT 2010


Christian Ebert <blacktrash at gmx.net> writes:

> * Martin Geisler on Wednesday, March 17, 2010 at 11:03:50 +0100
>> Christian Ebert <blacktrash at gmx.net> writes:
>>> These 4 patches deal with keyword's verbosity when overwriting
>>> (commit, kwexpand, kwshrink) and in kwdemo.
>>> 
>>> overwrite: simply use ui.note, do not customize verbosity.
>>>           Makes hg commit -v more verbose, but there is no need
>>>           for keyword to have a "customized" verbose option.
>>> 
>>> kwdemo: restrain information strictly to keyword related stuff.
>>>        At the same time a bit of a cleanup for this messy
>>>        function.
>> 
>> Thanks, I like how this simplifies the code. Pushed to crew.
>> 
>> I was debating whether the extra output in 'hg commit -v' will
>> confuse scripts that parse the output. But I'm not sure why a script
>> would parse the output to get the list of committed files when 'hg
>> status' is more suited for this.
>
> I've debated this with myself some more, because it still feels
> somewhat unclean.
>
> The following does this:
>
> - keep / revert to previous behaviour for hg commit -v
>   (no messages)
> - change the message format for hg commit --debug to a simple
>   one-liner
>
> Advantage: clear distinction between hg commit and
>            kwexpand/kwshrink, hopefully in the code as well
>
> Disadvantage: slightly more code than current version
>
> What do you think?

I would like to see the filenames that are affected, so I prefer the
current output. But perhaps we should just change change it use
ui.debug?

-- 
Martin Geisler

Fast and powerful revision control: http://mercurial.selenic.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20100401/81441298/attachment.pgp>


More information about the Mercurial-devel mailing list