Code review/Feedback needed for new extension

Martin Geisler mg at aragost.com
Fri May 7 10:39:06 CDT 2010


Greg Ward <greg-hg at gerg.ca> writes:

> On Thu, May 6, 2010 at 3:08 PM, Sylvain Hamel <redhotsly at hotmail.com> wrote:

> Also, you should document that playing games like
>
>   [macros]
>   funkylog = log -k"foo;bar"
>
> will NOT work... i.e. that you are doing a simple naive split on
> semicolon.

Hmm... What about using the newly added configlist functionality?

Then one would use double quotes around each macro:

  [macros]
  funky = "log -k 'foo;bar'", push, pull

I know a semi-colon looks better, but the list syntax uses a clever
parser and the double quotes uses can be escaped. See the help text
here:

  http://selenic.com/hg/rev/0a548640e012#l1.14

-- 
Martin Geisler

aragost Trifork
Professional Mercurial support
http://aragost.com/mercurial/


More information about the Mercurial-devel mailing list