[PATCH 2 of 4] commit: warn when resurrecting a closed changeset

Gilles Moris gilles.moris at free.fr
Wed May 12 02:53:01 CDT 2010


On Tuesday 11 May 2010 11:15:11 am Sune Foldager wrote:
> On 09-05-2010 22:50, Gilles Moris wrote:
> > +    if not opts.get('close_branch'):
> > +        for r in parents:
> > +            if repo[r].extra().get('close'):
> > +                ui.status(_('resurrecting closed changeset %d\n') % r)
>
> Is ui.status the correct thing to use. Your headline says 'warn'.
>
> /Sune

May be the headline should say "inform".
It's suppose to be at the same level of information than "create new head", 
which use ui.status(), i.e. printed if --quiet is not set.

Regards.
Gilles.



More information about the Mercurial-devel mailing list