[PATCH stable] pager: fork and exec pager as parent process

Yuya Nishihara yuya at tcha.org
Tue May 18 05:04:48 CDT 2010


Christian Ebert wrote:
> * Brodie Rao on Monday, May 03, 2010 at 14:06:22 -0500
> > # HG changeset patch
> > # User Brodie Rao <brodie at bitheap.org>
> > # Date 1272913234 18000
> > # Branch stable
> > # Node ID d7625733fa0f33b913f7432941ba436f4645cea9
> > # Parent  b8d0b4721affa90241f304272e0836ba566d0b3a
> > pager: fork and exec pager as parent process
> > 
> > With the pager as the child process instead of the parent process, the
> > termination of the parent Mercurial process can cause the terminal to return
> > before the pager exits. Inverting the relationship prevents that issue.
> > 
> > Platforms without fork() will continue to use util.popen().
> 
> I lose color in the pager with this patch. Might be because I
> only started playing recently with both extensions. Still ...

If you're on default branch, the following patch should fix the issue:

> # HG changeset patch
> # User Yuya Nishihara <yuya at tcha.org>
> # Date 1274176514 -32400
> # Node ID 7e30407ff76d2580db589021741c00d4fbd0ddee
> # Parent  c45a47bc41148b6037cd7337c4529a5e67b92222
> color: bring back colors with pager
> 
> It's introduced by 3c368a1c962d, but missing in merge changeset
> at a890cc501501.

Yuya,


More information about the Mercurial-devel mailing list