[PATCH 0 of 2] make util.atomictempfile more convenient

Yuya Nishihara yuya at tcha.org
Wed May 26 12:04:32 CDT 2010


Steve Borho wrote:
> On Fri, May 21, 2010 at 11:33 AM, Matt Mackall <mpm at selenic.com> wrote:
> > On Fri, 2010-05-21 at 20:17 +0900, Yuya Nishihara wrote:
> >> First patch makes mode and createmode of atomictempfile()
> >> optional.
> >>
> >> Second patch add the ability to copy extra file attributes
> >> on Windows. Mostly it's for "hidden" flag.
> >
> > Why are you using the hidden flag?
> 
> I think that was my exact initial response.
> 
> http://bitbucket.org/tortoisehg/stable/issue/240/unable-to-write-to-configuration-file-if-mercurialini-is
> 
> It seems users like to hide their Mercurial.ini, .hgignore and similar
> files.  We have tools that update those files, and those tools use
> atomictempfile().
> 
> We could handle this entirely on our side, but it seemed friendlier to
> add this capability to the mercurial class.

Yes, I thought it's good to utilize Mercurial's code as possible.

If the change to handle "hidden" attr seems complicated for Mercurial,
I'll patch it on TortoiseHg side.

Yuya,


More information about the Mercurial-devel mailing list