Patch adding a "changesetdiff" command to hgwebdir

[Greg Ward]

On Fri, Oct 29, 2010 at 7:45 AM, Radomir Dopieralski <sheep at stxnext.pl> wrote:
> The following patch, written by Tomasz Nowicki, adds a new command do
> hgweb, allowing it do display a diff between any two revisions, not
> just consecutive revisions.

Thanks for your contribtion -- or rather, for Tomasz' contribution.
The usual convention is that the author of a patch should be credited
for his work, i.e. the patch you emailed should say: "User Tomasz
Nowicki <...>".

> We are using this in our local hgweb install to review differences
> bewteen different tagged releases of our software.
>
> The patch is rather long, because it adds a new template in every one
> of available skins -- the changes in code itself are small.

Note that Mercurial was in feature freeze for the 1.7 release when you
sent your patch, which is probably why nobody responded.  You might
want to wait until 1.7 is released (should be today) and has a few
days to shake out bugs, and then try resending.

> I have applied it successfully against revision 12873:e1855dee28c1 in
> the http://selenic.com/repo/hg repository and ran the tests. The
> results are as follow:
>
> Skipped test-casefolding.t: missing feature: case insensitive file system
> Skipped test-convert-baz: missing feature: GNU Arch baz client
> Skipped test-convert-darcs.t: missing feature: darcs client
> Skipped test-convert-hg-svn.t: missing feature: subversion python bindings
> Skipped test-convert-mtn.t: missing feature: monotone client (> 0.31)
> Skipped test-convert-p4: missing feature: Perforce server and client
> Skipped test-convert-p4-filetypes: missing feature: Perforce server and client
> Skipped test-convert-svn-branches.t: missing feature: subversion python bindings
> Skipped test-convert-svn-encoding.t: missing feature: subversion python bindings
> Skipped test-convert-svn-move.t: missing feature: subversion python bindings
> Skipped test-convert-svn-sink.t: missing feature: subversion python bindings
> Skipped test-convert-svn-source.t: missing feature: subversion python bindings
> Skipped test-convert-svn-startrev.t: missing feature: subversion python bindings
> Skipped test-convert-svn-tags.t: missing feature: subversion python bindings
> Skipped test-convert-tla.t: missing feature: GNU Arch tla client
> Skipped test-no-symlinks: system supports symbolic links
> Failed test-convert-cvs-branch.t: output changed
> Failed test-convert-cvs-detectmerge.t: output changed
> Failed test-convert-cvs-synthetic.t: output changed
> Failed test-convert-cvs.t: output changed
> Failed test-convert-cvsnt-mergepoints.t: output changed
> # Ran 392 tests, 16 skipped, 6 failed.

We try very hard not to accept patches that break the test suite.  So
you need to unapply the patch and see if the tests are still broken.
If so, try to figure out why.  It's perfectly fine to ask for help.
We like it when the tests pass, so if they don't pass for you, that's
a problem.

If your -- err, Tomasz' -- patch actually breaks the tests, you need
to figure out why and fix it.

If the tests are equally broken with and without Tomasz' patch, that's
good news for you... but it really would be strongly preferable if you
could honestly say, "the test suite passes with this patch applied".

Thanks for your contribution!

Greg