[issue2484] localrepo._filecommit gets None in crev

[Matt Mackall]

On Wed, 2010-11-10 at 13:08 +0100, Mads Kiilerich wrote:
> On 11/10/2010 08:20 AM, Matt Mackall wrote:
> >
> > New submission from Matt Mackall<mpm at selenic.com>:
> >
> > A number of bug reports include this in the traceback:
> >
> >    File "/usr/local/lib/python2.5/site-packages/mercurial/localrepo.py", line
> > 761, in _filecommit
> >      self.ui.debug(_(" %s: copy %s:%s\n") % (fname, cfname, hex(crev)))
> > TypeError: b2a_hex() argument 1 must be string or read-only buffer, not None
> >
> > Unifying them under this issue.
> >
> > ----------
> > messages: 14341
> > nosy: mpm
> > priority: bug
> > status: unread
> > title: localrepo._filecommit gets None in crev
> 
> Matt, you have previously hinted that it is different bugs that happens 
> to give the same inconsistency and error message. Issue2460 is a recent 
> example of such a bug that got fixed.
> 
> Do you see a common root cause or do you want a common workaround or 
> what's up?

All of these are related to apparently nonsensical copy data in the
dirstate. I don't think we're going to make much progress on them until
we start reporting a useful error message. And that useful error message
will probably reveal some useful patterns in how we're getting here.

-- 
Mathematics is the supreme nostalgia of our time.